Skip to content

tools: add missing highway defines for IBM i #58335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 17, 2025
Merged

tools: add missing highway defines for IBM i #58335

merged 1 commit into from
May 17, 2025

Conversation

abmusse
Copy link
Contributor

@abmusse abmusse commented May 14, 2025

This was added for AIX but should have included IBM i as well.

@abmusse
tools: add missing highway defines for IBM i
26fbdac 
This was added for AIX but should have included IBM i as well.
@abmusse abmusse requested review from targos, richardlau and mhdawson May 14, 2025 16:50
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels May 14, 2025
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label May 15, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 15, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66816/

mhdawson
mhdawson approved these changes May 16, 2025
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66843/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6562/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6562/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6562/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66846/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66850/

@abmusse abmusse added the ibm i Issues and PRs related to the IBM i platform. label May 17, 2025
@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label May 17, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 17, 2025
@nodejs-github-bot nodejs-github-bot merged commit 41b9263 into nodejs:main May 17, 2025
75 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 41b9263

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@richardlau richardlau richardlau approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
ibm i Issues and PRs related to the IBM i platform. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@abmusse @nodejs-github-bot @lpinca @targos @richardlau @mhdawson